[Lldb-commits] [lldb] r270863 - [cmake] Remove the LLDB versions of the exception-controlling variables
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Thu May 26 09:11:05 PDT 2016
Author: labath
Date: Thu May 26 11:11:04 2016
New Revision: 270863
URL: http://llvm.org/viewvc/llvm-project?rev=270863&view=rev
Log:
[cmake] Remove the LLDB versions of the exception-controlling variables
Summary:
One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_RTTI. It's not
clear to me why one would want to control these at lldb level and it's generally not even a good
idea to compile parts of the same binary with different values of these flags.
Reviewers: zturner, tfiala
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D20673
Modified:
lldb/trunk/cmake/modules/LLDBConfig.cmake
Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/LLDBConfig.cmake?rev=270863&r1=270862&r2=270863&view=diff
==============================================================================
--- lldb/trunk/cmake/modules/LLDBConfig.cmake (original)
+++ lldb/trunk/cmake/modules/LLDBConfig.cmake Thu May 26 11:11:04 2016
@@ -338,28 +338,6 @@ if (HAVE_LIBDL)
list(APPEND system_libs ${CMAKE_DL_LIBS})
endif()
-if(LLDB_REQUIRES_EH)
- set(LLDB_REQUIRES_RTTI ON)
-else()
- if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
- set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} -fno-exceptions")
- elseif(MSVC)
- add_definitions( -D_HAS_EXCEPTIONS=0 )
- set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} /EHs-c-")
- endif()
-endif()
-
-# Disable RTTI by default
-if(NOT LLDB_REQUIRES_RTTI)
- if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
- set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} -fno-rtti")
- elseif(MSVC)
- set(LLDB_COMPILE_FLAGS "${LLDB_COMPILE_FLAGS} /GR-")
- endif()
-endif()
-
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${LLDB_COMPILE_FLAGS}")
-
if (CMAKE_SYSTEM_NAME MATCHES "Linux")
# Check for syscall used by lldb-server on linux.
# If these are not found, it will fall back to ptrace (slow) for memory reads.
More information about the lldb-commits
mailing list