[Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu May 26 01:41:34 PDT 2016

labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.

Looks great now. Thanks.

Comment at: packages/Python/lldbsuite/test/test_categories.py:62
@@ +61,3 @@
+            if not gmodules.is_compiler_clang_with_gmodules(compiler_path):
+                # Ideally in a multi-compiler scenario during a single test run, this would
+                # allow gmodules on compilers that support it and not on ones that don't.
So, one way to achieve that would be to move the logic that decides whether to run these tests to a later stage -- to check the conditions during test running, not test generation. This would make this behave the same way as all the other skip decorators -- the test would be skipped instead of "not generated at all".

But I don't think we should do this now.


More information about the lldb-commits mailing list