[Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed May 25 03:55:33 PDT 2016

labath added inline comments.

Comment at: unittests/Utility/ModuleCacheTest.cpp:74
@@ +73,3 @@
+    HostInfo::Initialize();
+    ObjectFileELF::Initialize();
ovyalov wrote:
> If it's one-off initialization can we use setUpTestCase for these purposes (for HostInfo::Initialize and ObjectFileELF::Initialize)?
Good point. I have moved this to the static method (including the variable initialization below, as they are not modified). I have also added the corresponding tearDown method.



More information about the lldb-commits mailing list