[Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D19998#438529, @zturner wrote:

> In `is_compiler_clang_with_gmodules` you will need to explicitly return false if the target is Windows, because clang help will still show the command line option as being valid, even though it doesn't work properly.


Ah okay.

Two code paths call that, one is guarded against Windows, but the very last change for that one single gmodules-only test uses the decorator that doesn't guard.  (I had mis-expected that -gmodules would just be missing entirely from the Windows end).

Adrian is about to put up the patch set.  I'll catch him and we'll modify that before it goes up.


http://reviews.llvm.org/D19998