[Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue May 24 10:09:38 PDT 2016

labath added a comment.

I like the idea of having a centralized place defining "invalid characters". However, I am not sure if that needs to be (at least in this case) system-dependent. Since presumably the code will need to work on all platforms anyway, having the escaping done in a divergent manner will just complicate testing. I don't see a reason to not define the illegal characters as a union of illegal characters across all platforms (which basically means, using the windows set).


More information about the lldb-commits mailing list