[Lldb-commits] [lldb] r270365 - Reword ThreadSanitizer messages to use a lowercase 't' in thread names when in the middle of a sentence.

Kuba Brecka via lldb-commits lldb-commits at lists.llvm.org
Sun May 22 07:56:40 PDT 2016


Author: kuba.brecka
Date: Sun May 22 09:56:33 2016
New Revision: 270365

URL: http://llvm.org/viewvc/llvm-project?rev=270365&view=rev
Log:
Reword ThreadSanitizer messages to use a lowercase 't' in thread names when in the middle of a sentence.


Modified:
    lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp

Modified: lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp?rev=270365&r1=270364&r2=270365&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp (original)
+++ lldb/trunk/source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp Sun May 22 09:56:33 2016
@@ -636,10 +636,10 @@ ThreadSanitizerRuntime::GetLocationDescr
             result = Sprintf("Location is a %ld-byte heap object at 0x%llx", size, addr);
         } else if (type == "stack") {
             int tid = loc->GetAsDictionary()->GetValueForKey("thread_id")->GetAsInteger()->GetValue();
-            result = Sprintf("Location is stack of Thread %d", tid);
+            result = Sprintf("Location is stack of thread %d", tid);
         } else if (type == "tls") {
             int tid = loc->GetAsDictionary()->GetValueForKey("thread_id")->GetAsInteger()->GetValue();
-            result = Sprintf("Location is TLS of Thread %d", tid);
+            result = Sprintf("Location is TLS of thread %d", tid);
         } else if (type == "fd") {
             int fd = loc->GetAsDictionary()->GetValueForKey("file_descriptor")->GetAsInteger()->GetValue();
             result = Sprintf("Location is file descriptor %d", fd);
@@ -766,7 +766,7 @@ GenerateThreadName(std::string path, Str
         bool is_atomic = o->GetObjectForDotSeparatedPath("is_atomic")->GetBooleanValue();
         addr_t addr = o->GetObjectForDotSeparatedPath("address")->GetIntegerValue();
         
-        result = Sprintf("%s%s of size %d at 0x%llx by Thread %d", is_atomic ? "atomic " : "", is_write ? "write" : "read", size, addr, thread_id);
+        result = Sprintf("%s%s of size %d at 0x%llx by thread %d", is_atomic ? "atomic " : "", is_write ? "write" : "read", size, addr, thread_id);
     }
     
     if (path == "threads") {
@@ -779,9 +779,9 @@ GenerateThreadName(std::string path, Str
         int thread_id = o->GetObjectForDotSeparatedPath("thread_id")->GetIntegerValue();
         int fd = o->GetObjectForDotSeparatedPath("file_descriptor")->GetIntegerValue();
         if (type == "heap") {
-            result = Sprintf("Heap block allocated by Thread %d", thread_id);
+            result = Sprintf("Heap block allocated by thread %d", thread_id);
         } else if (type == "fd") {
-            result = Sprintf("File descriptor %d created by Thread %t", fd, thread_id);
+            result = Sprintf("File descriptor %d created by thread %t", fd, thread_id);
         }
     }
     




More information about the lldb-commits mailing list