[Lldb-commits] [PATCH] D20312: Fix function name lookup in IRExecutionEngine.cpp.

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu May 19 12:43:16 PDT 2016

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

See inlined comments.

Comment at: source/Expression/IRExecutionUnit.cpp:128
@@ -127,3 +127,3 @@
-        if (function.m_name.AsCString() != m_name.AsCString())
+        if (function.m_name.AsCString() == m_name.AsCString())
If "function.m_name" is a lldb_private::ConstString and so it "m_name", then please do this comparison as:

if (function.m_name == m_name)

Check with Sean to see if changing != to == is the correct thing.


More information about the lldb-commits mailing list