[Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu May 19 03:48:18 PDT 2016

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

This adds a lot of code duplication, which should be trivial to remove. Please address that first.

Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:165
@@ -163,1 +164,3 @@
 	ifeq "$(ARCH)" "aarch64"
+		OBJCOPY := $(if $(findstring gcc,$(CC)), \
+			$(subst gcc,objcopy,$(CC)), \
This looks like it duplicates the `replace_cc_with` logic in the Android specific-code. Please move the macro to a common location and then use it here. I'd like to avoid adding more cryptic make code.

In fact, the android specific definitions can probably be removed after this goes in (we can do that as a followup if you don't have the ability to test it).


More information about the lldb-commits mailing list