[Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

[Zachary Turner via lldb-commits]

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

Looks good on Windows with the two suggested fixes.


================
Comment at: source/Interpreter/CommandObject.cpp:339
@@ -338,3 +338,3 @@
     m_exe_ctx.Clear();
-    m_api_locker.Unlock();
+    m_api_locker.unlock();
 }
----------------
```
if (m_api_locker)
    m_api_locker.unlock();
```

Otherwise this is undefined behavior.  Also make sure you do this check anywhere else in the patch where you do manual unlocking / locking like this.

================
Comment at: source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp:404
@@ -404,2 +403,3 @@
+
         auto lock = m_interpreter->AcquireInterpreterLock(); // to make sure thread_info_dict stays alive
         StructuredData::DictionarySP thread_info_dict = m_interpreter->OSPlugin_CreateThread(m_python_object_sp, tid, context);
----------------
change this to `auto interpreter_lock` so it doesn't redefine `lock` from line 186


Repository:
  rL LLVM

http://reviews.llvm.org/D20351