[Lldb-commits] [PATCH] D20344: [LLDB] Fix standalone LLDB build when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Wed May 18 02:26:21 PDT 2016
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me. Let's give others a chance to respond though.
================
Comment at: cmake/modules/LLDBStandalone.cmake:103
@@ -98,2 +102,3 @@
include("${LLVM_OBJ_ROOT}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm/LLVMConfig.cmake")
- include("${LLVM_OBJ_ROOT}/lib${LLVM_LIBDIR_SUFFIX}/cmake/clang/ClangConfig.cmake")
+ if (EXISTS "${LLVM_OBJ_ROOT}/lib${LLVM_LIBDIR_SUFFIX}/cmake/clang/ClangConfig.cmake")
+ include("${LLVM_OBJ_ROOT}/lib${LLVM_LIBDIR_SUFFIX}/cmake/clang/ClangConfig.cmake")
----------------
Please add a comment about when do we expect this files to exist. (I.e., when building against clang which was configured and built together with llvm).
================
Comment at: cmake/modules/LLDBStandalone.cmake:113
@@ -106,1 +112,3 @@
include_directories("${LLVM_BINARY_DIR}/include" "${LLVM_MAIN_INCLUDE_DIR}")
+ if (EXISTS "${LLVM_OBJ_ROOT}/include")
+ include_directories("${LLVM_OBJ_ROOT}/include")
----------------
Please add a comment about when do we expect these files to exist. (I.e., when building against an not-installed copy of llvm which is still sitting in its build directory).
Repository:
rL LLVM
http://reviews.llvm.org/D20344
More information about the lldb-commits
mailing list