[Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue May 17 17:35:04 PDT 2016

zturner added a comment.

This looks good, no probelms on Windows that I can see.  I ran clang-format on your patch just to confirm, and it fixed up some trailing whitespace at the end of lines.  I'm not sure if the problem was in the generation of the patch on your end, the application of the patch on my end, or if the whitespace is really there on your end too, but just make sure it's all clean.  Quick example just so you can look at this specific line and see if it's on your end:

   // Other libraries and framework includes
   // Project includes
  diff --git a/include/lldb/Core/History.h b/include/lldb/Core/History.h
  index 001ad3e..164d1bf 100644
  --- a/include/lldb/Core/History.h
  +++ b/include/lldb/Core/History.h
  @@ -46,7 +46,7 @@ public:
       // onto the end of the history stack.
       virtual HistoryEvent
  -    CreateHistoryEvent () = 0;
  +    CreateHistoryEvent () = 0;

This line had whitespace at the end when I applied the patch.


More information about the lldb-commits mailing list