[Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

Saleem Abdulrasool via lldb-commits lldb-commits at lists.llvm.org
Mon May 16 17:41:53 PDT 2016

compnerd added a comment.

Zach is correct, this doesn't *remove* the Mutex and Condition types, merely starts reducing the easier uses of it.

My thinking is to do this piecemeal, slowly reducing the local usage until the real uses remain in the cases where we need to actually change the structure of the code.  In particular, it seems that there are places where we have `Mutex::Locker` passed in by reference to get a lock.

I agree that we want to start moving towards using std::condition_variable, however, that was a bit more involved as that will require adding a conversion operator for TimeValue.  Switching to `std::condition_variable` requires the switch to `std::mutex` as `std::conditional_variable::wait` requires a `std::unique_lock<std::mutex>`.

I wanted to get as much of the mechanical change out of the way as possible so that when the rest of the uses are removed, it is easier to actually review the change to ensure that no subtle bugs are being introduced since it won't be as mechanical.


More information about the lldb-commits mailing list