[Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon May 16 02:13:53 PDT 2016

labath added a subscriber: labath.
labath added a comment.

In http://reviews.llvm.org/D20278#430658, @krytarowski wrote:

> Looks good, however could we merge firstly Plugins/Process/NetBSD http://reviews.llvm.org/D20274 ? Otherwise I will need to keep syncing my patch forever for generic changes.
> Thanks!

I don't think we should connect these two patches in any way. What you are asking for here amounts to "let **me** merge my patch first, so that **you** can deal with the merge conflicts".

Also, I think merge conflicts for this patch, if we let it go stale, will be more painful that for the netbsd process plugin, as that localized to a certain set of files.

I gave the patch a quick run, and I've noticed no regressions on Linux (after fixing up a couple of compile errors in Linux-specific code), so +100 on the patch from me.

As for the compile errors, I'm going to prepare NativeProcessLinux ahead of time for this patch, to avoid breakage.


More information about the lldb-commits mailing list