[Lldb-commits] [lldb] r268827 - Remove some lldbassert's from the packet checking code.

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Fri May 6 17:52:18 PDT 2016


Author: jingham
Date: Fri May  6 19:52:18 2016
New Revision: 268827

URL: http://llvm.org/viewvc/llvm-project?rev=268827&view=rev
Log:
Remove some lldbassert's from the packet checking code.

Greg says he doesn't need these asserts anymore and since they cause occasional test suite
crashes, out they go.

Modified:
    lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp

Modified: lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp?rev=268827&r1=268826&r2=268827&view=diff
==============================================================================
--- lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp (original)
+++ lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp Fri May  6 19:52:18 2016
@@ -14,7 +14,6 @@
 // Other libraries and framework includes
 // Project includes
 #include "Utility/StringExtractorGDBRemote.h"
-#include "lldb/Utility/LLDBAssert.h"
 
 StringExtractorGDBRemote::ResponseType
 StringExtractorGDBRemote::GetResponseType () const
@@ -405,7 +404,6 @@ OKErrorNotSupportedResponseValidator(voi
         case StringExtractorGDBRemote::eResponse:
             break;
     }
-    lldbassert(!"Packet validatation failed, check why this is happening");
     return false;
 }
 
@@ -438,7 +436,6 @@ JSONResponseValidator(void *, const Stri
             }
             break;
     }
-    lldbassert(!"Packet validatation failed, check why this is happening");
     return false;
 }
 
@@ -463,7 +460,6 @@ ASCIIHexBytesResponseValidator(void *, c
                 {
                     if (!isxdigit(ch))
                     {
-                        lldbassert(!"Packet validatation failed, check why this is happening");
                         return false;
                     }
                     if (++valid_count >= 16)
@@ -473,7 +469,6 @@ ASCIIHexBytesResponseValidator(void *, c
             }
             break;
     }
-    lldbassert(!"Packet validatation failed, check why this is happening");
     return false;
 }
 




More information about the lldb-commits mailing list