[Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

[Adrian Prantl via lldb-commits]

aprantl created this revision.
aprantl added reviewers: granata.enrico, tfiala.
aprantl added a subscriber: lldb-commits.

This is a work-in-progress patch for adding a "-gmodules" category to the testsuite. It adds clang module debugging as a configuration alongside .dSYM and DWO to ensure that module debug info is getting broader coverage. When enabled it will add "-fmodules -gmodules" to CFLAGS (but not CXXFLAGS). It will not invoke dsymutil, since dsymutil undoes most of the module-related intricacies.

In the current form, this passes the test suite on Darwin, and it should also work on any other platform that uses clang as the host compiler.

I do have a couple of remaining questions regarding the implementation:
- Is there a way to detect that clang is the host compiler, so we can disable the category on platforms that use a different compiler?
- The "-fmodules" and "-gmodules" are only well supported by clang-3.9 and later. Is there a good way to test for this in is_supported_on_platform() or somewhere else?

http://reviews.llvm.org/D19998

Files:
  packages/Python/lldbsuite/test/lldbinline.py
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/make/Makefile.rules
  packages/Python/lldbsuite/test/plugins/builder_base.py
  packages/Python/lldbsuite/test/test_categories.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19998.56351.patch
Type: text/x-patch
Size: 5023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160505/c0b3c591/attachment.bin>