[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue May 3 08:16:36 PDT 2016

labath added a comment.

This is going to be messier than I expected. I would need to introduce the same repeat-until-the-buffer-is-full loop into ConnectionGenericFileWindows, which I don't think is good for code reuse. I see two possibilities:

- go back to the version with a separate function for this behavior (with the timeout problem fixed)
- keep the fix completely within the AdbClient class.

Which one do you prefer?



More information about the lldb-commits mailing list