[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue May 3 05:38:37 PDT 2016
labath added inline comments.
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 1000000; // 1 second
+const uint32_t kReadTimeout = 4000000; // 4 seconds
const char * kOKAY = "OKAY";
> It might be useful to expose this timeout as a settings property to allow its customization for slow ADB connections.
We can do it later if a need appears, but I don't see how making that a setting -- the value needs to be big enough to work under all circumstances, and in case of normal operation, it will not matter, as the function will return as soon as the data is ready.
More information about the lldb-commits