[Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2

[Zachary Turner via lldb-commits]

I don't think we should be adding more CMake hacks in lldb when llvm is
supposed to handle this. Why don't the existing lines work?
On Sat, Apr 30, 2016 at 4:24 PM Kamil Rytarowski <n54 at gmx.com> wrote:

> krytarowski added a comment.
>
> I had this working with 2.8:
>
>   --- source/Plugins/SymbolFile/PDB/CMakeLists.txt.orig   2016-04-27
> 00:55:50.000000000 +0000
>   +++ source/Plugins/SymbolFile/PDB/CMakeLists.txt
>   @@ -1,7 +1,11 @@
>   -set(LLVM_PRIVATE_LINK_COMPONENTS
>   -    DebugInfoPDB)
>   +#set(LLVM_PRIVATE_LINK_COMPONENTS
>   +#    DebugInfoPDB)
>
>    add_lldb_library(lldbPluginSymbolFilePDB
>      PDBASTParser.cpp
>      SymbolFilePDB.cpp
>      )
>   +
>   +target_link_libraries(lldbPluginSymbolFilePDB
>   +LINK_PRIVATE
>   +LLVMDebugInfoPDB)
>
> I'm going to test build lldb with 2.8.12.2.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D19685
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160430/bc9c3b50/attachment.html>