[Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

[Saleem Abdulrasool via lldb-commits]

compnerd accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149
@@ +148,3 @@
+                {
+                    spec.SetTriple("armv7-pc-windows");
+                    specs.Append(ModuleSpec(file, spec));
----------------
This may be a bit tricky.  `armv7-windows` is unsupported in LLVM/clang (and we silently rewrite that in the clang frontend), and you need `thumbv7-windows` (ARM NT).  Though, it is possible that LLDB is unable to handle that distinction right now.

That said, the `pc` vendor is silly, and `unknown` sounds better to me, but this shouldn't matter too much.

Finally, the Windows environment defaults to `msvc` here, which has a slight issue that it can sometimes fail to generate an assembly listing (the code generation is correct, its just a serialization issue caused by not having invested sufficiently in generating MASM style assembly listing).

The safest triple would be `thumbv7-unknown-windows-itanium`.  But, if lldb is going to ensure that the code is handled as thumb, using `armv7` should be fine.


http://reviews.llvm.org/D19604