[Lldb-commits] [PATCH] D19685: Fix NetBSD build with CMake 3.5.2
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 29 01:39:11 PDT 2016
labath added a reviewer: zturner.
labath added a comment.
cmake 2.8 is still widely used (Ubuntu 14.04 LTS for one, but there are people around using even longer lived versions of RedHat). I don't think we should bump the version over a tiny detail like this. I'm pretty sure there is a way to rewrite the target rules to be compatible with both cmake 2.8 and 3+. Adding zachary for more insight.
A couple of other random thoughts:
- LLVM specifies the minimum version as 22.214.171.124. I think it's safe to go up to that point. Would that make any difference in this case?
- For the NetBSD target, I think you are free to choose whichever minimal version of cmake you like (although I would suggest to not go too far). However, you still need to make sure the build works with cmake 2.8 for others. Is it possible to fix your libexecinfo problem by conditionally changing the minimum version, or setting setting some policy?
More information about the lldb-commits