[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient
Oleksiy Vyalov via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 28 10:47:09 PDT 2016
ovyalov added a comment.
LGTM
================
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 1000000; // 1 second
+const uint32_t kReadTimeout = 4000000; // 4 seconds
const char * kOKAY = "OKAY";
----------------
It might be useful to expose this timeout as a settings property to allow its customization for slow ADB connections.
http://reviews.llvm.org/D19533
More information about the lldb-commits
mailing list