[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 26 09:43:09 PDT 2016
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
The "timeout_usec" parameter to Connection::ReadAll() doesn't seem like it is doing what is intended. It uses this timeout for every read call which means the Connection::ReadAll() function could take much longer. If the timeout was say 1 second and every 0.9 seconds we get 1 byte, this function could take a very long time to complete. So that should be fixed. It also seems like ReadAll() could be done by adding an extra parameter to the Read() function like "bool keep_reading_until_timeout".
More information about the lldb-commits