[Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

[Pavel Labath via lldb-commits]

labath added a subscriber: labath.
labath accepted this revision.
labath added a reviewer: labath.
This revision is now accepted and ready to land.

================
Comment at: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp:253
@@ +252,3 @@
+    ValueObjectSP allgs_sp = FindGlobal(target_sp,  "runtime.allgs");
+    if (allgs_sp) {
+        m_allg_sp = allgs_sp->GetChildMemberWithName(ConstString("array"), true);
----------------
To me, as someone who might accidentally wander into this part of codebase, a comment explaining that the symbols to look for differ between runtime versions would definitely be helpful.


Repository:
  rL LLVM

http://reviews.llvm.org/D19273