[Lldb-commits] [PATCH] D19305: Use Process Plugin register indices when communicating with remote

[Jason Molenda via lldb-commits]

jasonmolenda added a comment.

This looks good to me.  Do you think the ReadRegister decl in GDBRemoteCommunicationClient.h should have a comment noting that the reg_num is a number in the remote register numbering scheme (eRegisterKindProcessPlugin)?  When lldb passes around register numbers internally, it is usually assuming the eRegisterKindLLDB register numbering convention.

(to be honest, I think we should have come up with a RegisterNumber class from the start - the presence of raw register numbers, with side knowledge about what register encoding should be used, makes it easy for mistakes to creep in.)


http://reviews.llvm.org/D19305