[Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

[Jason Molenda via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.

Hi Ulrich, sorry for the delayed reply, I wanted to look at this function again.

This function has gone through some modifications over its lifetime.  As you correctly point out, we're doing this back-up-by-one thing in two places and that's not needed.

I think you should remove the resolve_tail_call_address argument altogether around line 473 - take out the variable, the comment, everything.  Module::ResolveSymbolContextForAddress defaults this argument to 'false' if it isn't provided.

Please commit when you're ready, the details of this are up to you.


http://reviews.llvm.org/D18975