[Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

[Pavel Labath via lldb-commits]

labath added a comment.

In http://reviews.llvm.org/D19214#405204, @tfiala wrote:

> Okay I just looked at those, Pavel.
>
> They fall into a category that I know is not yet handled.  This is the category:
>
> - No test method is "open" (i.e. the dotest.py inferior is not in between a start_test/end_test) when the timeout occurs.  Thus, we cannot "charge" the timeout to a test method.  Thus, it gets charged to the file.


This is fine. I dont have an issue with the presentation of the results.

> 

> 

> - When we rerun, we currently do not clear file-level results.  (We should right before the rerun).

> 

>   This hadn't been prioritized because I haven't in practice run into timeouts that are occurring outside of a test method.  That implies either the startup or the shutdown of the python dotest.py inferior is hanging if you are consistently hitting that.  That in itself is an interesting event to investigate.


I'm not sure that is the case. The test that are reported as timed out are not doing anything special (testdefaultcachelinesize, testlistener) or are completely skipped on android (testpublicapiheader) so i'd be very surprised if we were seeing the timeouts there and nowhere else... It sounds more like a test runner bug to me...

In any case, i'll try to look into that once i finish dealing with other things bugging us. I just thought you should know about, as i think it could be related to this...


http://reviews.llvm.org/D19214