[Lldb-commits] [PATCH] D19230: Properly unload modules from target image list when using svr4 packets

[Todd Fiala via lldb-commits]

tfiala added inline comments.

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4907
@@ -4883,2 +4906,3 @@
+        m_process->GetTarget().ModulesDidUnload (removed_modules, false);
 
         new_modules.ForEach ([&target](const lldb::ModuleSP module_sp) -> bool
----------------
It looks like this code will unload any modules currently listed as loaded via m_process->GetTarget().GetImages(), if they do not appear in the module_list argument to this function.  Is that correct behavior?  (It might be, but that's not what I would have guessed without digging deeper).

I might be not following the flow here correctly, though.  Can you clarify?  Did the full test suite run with this change?  Thanks!


http://reviews.llvm.org/D19230