[Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

[Zachary Turner via lldb-commits]

They make the test suite run faster. when a file wasn't changed.

On Mon, Apr 18, 2016 at 11:34 AM Jim Ingham <jingham at apple.com> wrote:

> That I don't know.  But we really shouldn't be generating the .pyc files,
> they just litter the test directories and I don't think they are much help.
>
> Jim
>
> > On Apr 18, 2016, at 11:29 AM, Zachary Turner <zturner at google.com> wrote:
> >
> > That's normal, but why would that cause an issue for the test suite?
> What is leading to it thinking that it should execute a .pyc file in the
> first place?
> >
> > On Mon, Apr 18, 2016 at 11:25 AM Jim Ingham <jingham at apple.com> wrote:
> > IIRC, python will generate byte-compiled ".pyc" versions of the ".py"
> files automatically (and helpfully leave them in the CWD...)  We turned
> that off for the testsuite through some Python magic I don't think I ever
> knew, but if I did I've certainly forgotten it...  Anyway, sounds like that
> got turned back on again, and we should turn it off again...
> >
> > Jim
> >
> > > On Apr 18, 2016, at 11:01 AM, Zachary Turner via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
> > >
> > > It seems very strange to me to be changing a .pyc filename to a .py
> filename.  I think we should try to understand where the .pyc filename is
> coming from to begin with, and this is just masking the real error.
> > >
> > > On Mon, Apr 18, 2016 at 10:10 AM Pavel Labath via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
> > > labath accepted this revision.
> > > labath added a comment.
> > > This revision is now accepted and ready to land.
> > >
> > > Ok, makes sense then, thanks for making sure it's necessary.
> > >
> > > I don't quite understand how the string makes it's way there though,
> as the only place setting this field in the entire repository seems to be
> lldbinline.py
> > >
> > >
> > > http://reviews.llvm.org/D19215
> > >
> > >
> > >
> > > _______________________________________________
> > > lldb-commits mailing list
> > > lldb-commits at lists.llvm.org
> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> > > _______________________________________________
> > > lldb-commits mailing list
> > > lldb-commits at lists.llvm.org
> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160418/735b3114/attachment.html>