[Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D19215#403844, @labath wrote:

> So, I think I have already fixed the problem with r266192.


I was able to replicate just prior to applying the change, but I'll double check.

Regarding r266192 (which came through when I wasn't looking, sorry), that started showing up because somebody changed something where the test_filename attribute was no longer showing up on test case instances every place where it used to show up.  I suspect there was some test refactoring that did that.  (So it was a latent bug, on a code path that didn't used to get hit).

> This seems a bit like using a sledgehammer to kill a fly. If anything, I'd add an assert somewhere that makes sure the file names are in the right form to begin with.





http://reviews.llvm.org/D19215