[Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

[Todd Fiala via lldb-commits]

tfiala created this revision.
tfiala added a reviewer: labath.
tfiala added a subscriber: lldb-commits.

The race boiled down to this:

    If a test worker queue is able to run the test inferior and
    clean up before the dosep.py listener socket is spun up, and
    the worker queue is the last one (as would be the case when
    there's only one test rerunning in the rerun queue), then
    the test suite will exit the main loop before having a chance
    to process any test events coming from the test inferior or
    the worker queue job control.

    I found this race to be far more likely on fast hardware.
    Our Linux CI is one such example.  While it will show
    up primarily during meta test events generated by
    a worker thread when a test inferior times out or
    exits with an exceptional exit (e.g. seg fault), it only
    requires that the OS takes longer to hook up the
    listener socket than it takes for the final test inferior
    and worker thread to shut down.

http://reviews.llvm.org/D19214

Files:
  packages/Python/lldbsuite/test/dosep.py
  packages/Python/lldbsuite/test/dotest_channels.py
  packages/Python/lldbsuite/test/issue_verification/TestRerunTimeout.py.park
  packages/Python/lldbsuite/test/result_formatter.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19214.54027.patch
Type: text/x-patch
Size: 4245 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160418/70c95c27/attachment.bin>