[Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 15 17:15:11 PDT 2016

Don't use an environment variable, add a command line flag to the script
On Fri, Apr 15, 2016 at 3:27 PM Francis Ricci <fjricci at fb.com> wrote:

> fjricci added a comment.
> So I looked at `finishSwigPythonLLDB.py`, and it does look like that's
> where the bug is. This script sets the end of the symlink path with:
>   strSrc = os.path.join("lib", "liblldb" + strLibFileExtn)
> Note here that "lib" is hardcoded, and doesn't use the
> `LLVM_LIBDIR_SUFFIX`, which is why the symlink is broken. The only way I
> can think of to communicate this suffix from cmake into python would be by
> having cmake set an environment variable (presumably with the same name).
> Does this seem reasonable, or do you think there's a better solution?
> The solution from `finish-swig-Python-LLDB.sh` would also probably work
> (enforcing that liblldb.so and python2.7/site-packages/lldb be in the same
> directory). That solution actually would be more consistent with the way
> the unit test suite works anyway. It does seem less flexible though.
> http://reviews.llvm.org/D19067
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160416/945a2a13/attachment.html>

More information about the lldb-commits mailing list