[Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI
Nitesh Jain via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 13 22:10:11 PDT 2016
nitesh.jain added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626
@@ -1624,4 +1624,4 @@
if (arch_spec.GetMachine() == llvm::Triple::mips || arch_spec.GetMachine() == llvm::Triple::mipsel
|| arch_spec.GetMachine() == llvm::Triple::mips64 || arch_spec.GetMachine() == llvm::Triple::mips64el)
> Should we add a function like:
> bool ArchSpec::IsMIPS() const;
> Every patch I see for MIPS has these same four machine checks. If we add another we will need to update all places that do this..
I agree with you. We need to add above function so it will be easy for future updates. I will update the diff as per suggestion
More information about the lldb-commits