[Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

[Jason Molenda via lldb-commits]

jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.

These look like good changes to me, especially the SBThread fix - I'm surprised that hasn't caused a problem.  The DynamicLoader change should be unnecessary but I don't have a problem with that.  Tamas might want to speak to what he meant to do in DWARFASTParserJava.cpp there.  Greg Clayton should probably comment on the FormatEntity change.


================
Comment at: source/Core/FormatEntity.cpp:1016
@@ -1015,2 +1015,3 @@
             {
-                success &= item->DumpPrintableRepresentation(s,val_obj_display, custom_format);
+                if (item)
+                    success &= item->DumpPrintableRepresentation(s,val_obj_display, custom_format);
----------------
Greg should look at this.


http://reviews.llvm.org/D19086