[Lldb-commits] [lldb] r266072 - Fixup TestFdLeak

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 12 06:55:55 PDT 2016


Author: labath
Date: Tue Apr 12 08:55:54 2016
New Revision: 266072

URL: http://llvm.org/viewvc/llvm-project?rev=266072&view=rev
Log:
Fixup TestFdLeak

this test was unintentionally XFAILed due to a change in the behavior of the expectedFailure
decorator. Fix that. Also, mark the test as debug-info independent while I'm in there.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/avoids-fd-leak/TestFdLeak.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/avoids-fd-leak/TestFdLeak.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/avoids-fd-leak/TestFdLeak.py?rev=266072&r1=266071&r2=266072&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/avoids-fd-leak/TestFdLeak.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/avoids-fd-leak/TestFdLeak.py Tue Apr 12 08:55:54 2016
@@ -16,12 +16,15 @@ from lldbsuite.test.decorators import *
 def python_leaky_fd_version(test):
     import sys
     # Python random module leaks file descriptors on some versions.
-    return (sys.version_info >= (2, 7, 8) and sys.version_info < (2, 7, 10),
-            "Python random module leaks file descriptors in this python version")
+    if sys.version_info >= (2, 7, 8) and sys.version_info < (2, 7, 10):
+        return "Python random module leaks file descriptors in this python version"
+    return None
 
 
 class AvoidsFdLeakTestCase(TestBase):
 
+    NO_DEBUG_INFO_TESTCASE = True
+
     mydir = TestBase.compute_mydir(__file__)
 
     @expectedFailure(python_leaky_fd_version, "bugs.freebsd.org/197376")
@@ -56,7 +59,6 @@ class AvoidsFdLeakTestCase(TestBase):
 
     @expectedFailure(python_leaky_fd_version, "bugs.freebsd.org/197376")
     @expectedFailureAll(oslist=['freebsd'], bugnumber="llvm.org/pr25624 still failing with Python 2.7.10")
-    @expectedFlakeyLinux
     @skipIfWindows # The check for descriptor leakage needs to be implemented differently here.
     @skipIfTargetAndroid() # Android have some other file descriptors open by the shell
     def test_fd_leak_multitarget (self):




More information about the lldb-commits mailing list