[Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 7 09:25:46 PDT 2016

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks good.

Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626
@@ -1624,4 +1624,4 @@
                 if (arch_spec.GetMachine() == llvm::Triple::mips || arch_spec.GetMachine() == llvm::Triple::mipsel
                     || arch_spec.GetMachine() == llvm::Triple::mips64 || arch_spec.GetMachine() == llvm::Triple::mips64el)
Should we add a function like:

bool ArchSpec::IsMIPS() const;

Every patch I see for MIPS has these same four machine checks. If we add another we will need to update all places that do this..



More information about the lldb-commits mailing list