[Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

[Todd Fiala via lldb-commits]

CFLAGS_EXTRA didn't work because it then gets both -O0 and -O1 (for the
majority of our tests, Makefile.rules correctly assumes optimizations are
turned off for maximal debug info).  If that was the fix, that is
circumventing the check this test is doing.

What we really need (and I'll go back and add) is an explicit optimization
level variable for Makefile.rules that defaults to -O0 but allows
overriding.  That would most likely address this.  I'll go back to that
once I'm done with another task.

Thanks!

-Todd

On Wed, Apr 6, 2016 at 7:27 AM, Tamas Berghammer <tberghammer at google.com>
wrote:

> tberghammer added a comment.
>
> My guess is the root cause of the problem is that we are setting CFLAGS
> instead of appending to CLAFGS_EXTRA (I changed it in my followup CL)
>
>
> Users:
>   tfiala (Author)
>
> http://reviews.llvm.org/rL265498
>
>
>
>


-- 
-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160406/ad6d1a7c/attachment.html>