[Lldb-commits] [Diffusion] rL265498: make TestRegisterVariables slightly more resilient

[Todd Fiala via lldb-commits]

I think it's the -O1 that is screwing it up.  The test relies on setting
the optimization level, and then screws up the compiler's ability to find
the framework headers with more recent clangs on OS X (both in-tree built
and Xcode-delivered).  Ultimately OS X has been shifting where the
/usr/include files have been delivered for a while, and this then requires
telling clang where to find them one way or another.

Thanks for fixing.  I can dig into that more and make it cleaner, I had
some code in the Makefile.rules that normally handles that but wasn't for
some reason.  I'll have to look at what failed.  The change to the Makefile
was instigated by OS X hitting an error on build when building with the
in-tree clang.

-Todd

On Wed, Apr 6, 2016 at 3:41 AM, Tamas Berghammer <tberghammer at google.com>
wrote:

> tberghammer added subscribers: lldb-commits, tberghammer.
> tberghammer added a comment.
>
> This CL caused a lot of breakage across various Linux/Android builders. I
> created a fix at http://reviews.llvm.org/rL265527 but please verify it is
> still working with OSX after that
>
>
> /lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/Makefile:7-11
> This change breaks the test for remote debugging when running from OSX to
> anything else (e.g. android) as the cross compilers don't need this flag.
> Why you need this here and not in any of the other tests?
>
> Users:
>   tfiala (Author)
>
> http://reviews.llvm.org/rL265498
>
>
>
>


-- 
-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160406/e9c1dacf/attachment-0001.html>