[Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

[Eran Ifrah via lldb-commits]

eran.ifrah added inline comments.

================
Comment at: CMakeLists.txt:3-5
@@ -2,1 +2,5 @@
 
+if(MINGW_DEBUG)
+  # force debugging info into lldb sources
+  message("-- Building LLDB in Debug mode")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0")
----------------
Adding ` -mbig-obj` for some files might get me through this, but my workaround also does the job so I am going to stick with it
Re-building clang takes too long and I can't afford to waste more time on this

================
Comment at: source/API/CMakeLists.txt:74-85
@@ -73,6 +73,14 @@
 # want every single library taking a dependency on the script interpreters.
-target_link_libraries(liblldb PRIVATE
-  lldbPluginScriptInterpreterNone
-  lldbPluginScriptInterpreterPython
-  )
+if(MINGW)
+  target_link_libraries(liblldb PRIVATE
+    lldbPluginScriptInterpreterNone
+    lldbPluginScriptInterpreterPython
+    Dbghelp # Needed for MiniDumpWriteDump
+    )
+else()
+  target_link_libraries(liblldb PRIVATE
+    lldbPluginScriptInterpreterNone
+    lldbPluginScriptInterpreterPython
+    )
+endif()
 
----------------
labath wrote:
> I think you should add this library to `system_libs` in LLDBConfig.cmake. Then it should get linked in automatically.
Thanks, I was not aware of this variable. I moved `Dbghelp` to system_libs under Windows+MinGW


http://reviews.llvm.org/D18519