[Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 4 13:13:02 PDT 2016

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Close, we just need to remove the "Headers for" string. See inlined comment.

Comment at: source/Commands/CommandObjectTarget.cpp:1568
@@ +1567,3 @@
+                ObjectFile *objfile = module->GetObjectFile();
+                strm.Printf("Headers for '%s':\n", objfile->GetFileSpec().GetCString());
+                strm.IndentMore();
We should probably leave this for the objfile->Dump(...) to print.  "Headers for '%s'" doesn't make sense here. So this print should probably be removed, or just the filename should be printed out without the "Headers for" part.


More information about the lldb-commits mailing list