[Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 1 09:09:12 PDT 2016


What if you are simultaneously debugging 2 processes with the same pid?
Does this fail?
On Fri, Apr 1, 2016 at 9:06 AM Pavel Labath <labath at google.com> wrote:

> labath created this revision.
> labath added reviewers: clayborg, zturner.
> labath added a subscriber: lldb-commits.
>
> There was a bug in linux core file handling, where if there was a running
> process with the same
> process id as the id in the core file, the core file debugging would fail,
> as we would pull some
> pieces of information (ProcessInfo structure) from the running process
> instead of the core file.
> I fix this by routing the ProcessInfo requests through the Process class
> and overriding it in
> ProcessElfCore to return correct data.
>
> A (slightly convoluted) test is included.
>
> http://reviews.llvm.org/D18697
>
> Files:
>   include/lldb/Target/Process.h
>
> packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
>   source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
>   source/Plugins/Process/elf-core/ProcessElfCore.cpp
>   source/Plugins/Process/elf-core/ProcessElfCore.h
>   source/Target/Process.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160401/87bd690a/attachment.html>


More information about the lldb-commits mailing list