[Lldb-commits] [PATCH] D18646: Fix DWO breakage in r264909

[Greg Clayton via lldb-commits]

clayborg added a comment.

I don't mind asserts when they shouldn't happen if they are lldbassert calls since these are removed for release builds, but we can't just call assert and crash because something bad happened. LLDB is a shared library and a framework and it shouldn't crash no matter what happens if we can help it. We need to get rid of any of these kinds of asserts that can actually bring down LLDB and code it so it can deal with things. I am fine with adding logging that is always enabled for these cases, but this is just a bad design that is hitting LLDB is crashing all over the place recently. So we need to code things correctly to deal with bad things and add logging so we know when we see these cases. So please fix SymbolFileDWARFDwo::GetDIE() to not crash as suggested.


Repository:
  rL LLVM

http://reviews.llvm.org/D18646