[Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 31 09:27:49 PDT 2016

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

I question if ArchSpec::GetClangTargetABI() belongs in ArchSpec. It is very clang specific. Should this just be a function in ClangExpressionParser? Like:

  static std::string
  ClangExpressionParser::GetTargetABI (const ArchSpec &arch);

If no where else will require this target ABI, then this probably should not live in ArchSpec.



More information about the lldb-commits mailing list