[Lldb-commits] [PATCH] D18530: Move some functions from ClangASTContext to ClangUtil
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Wed Mar 30 10:52:16 PDT 2016
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
The main reason I don't like this is all of the merge headaches it will create for us. We merge to swift.org and then over into some internal git repos. We have like 5 branches that we are always propagating things over to. This kind of change looks good in top of tree, but causes a ton if issues down the line. So this is my main hesitation. If we could keep any functions that were in ClangASTContext in ClangASTContext, because that is where they really belong. I don't really like the ClangUtil.cpp file because it is actually doing clang::ASTContext related things so the functions actually belong in ClangASTContext from a design point of view. So I would rather see the ClangUtil.cpp file go away and have everything be back in ClangASTContext.cpp.
More information about the lldb-commits