[Lldb-commits] [lldb] r264733 - Revert the "build fix" in r264104

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 29 07:39:10 PDT 2016

Author: labath
Date: Tue Mar 29 09:39:10 2016
New Revision: 264733

URL: http://llvm.org/viewvc/llvm-project?rev=264733&view=rev
Revert the "build fix" in r264104

this was needed because lldb-mi temporarily contained references to private lldb symbols
(lldb_private namespace), which it shouldn't have. The situation has since been rectified and
this wasn't the right fix anyway, since it can lead to funny ODR violations.


Modified: lldb/trunk/tools/lldb-mi/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/CMakeLists.txt?rev=264733&r1=264732&r2=264733&view=diff
--- lldb/trunk/tools/lldb-mi/CMakeLists.txt (original)
+++ lldb/trunk/tools/lldb-mi/CMakeLists.txt Tue Mar 29 09:39:10 2016
@@ -82,8 +82,6 @@ if ( CMAKE_SYSTEM_NAME MATCHES "Windows"
 endif ()
 add_lldb_executable(lldb-mi ${LLDB_MI_SOURCES})
 target_link_libraries(lldb-mi liblldb)
@@ -91,8 +89,6 @@ if ( NOT CMAKE_SYSTEM_NAME MATCHES "Wind
   target_link_libraries(lldb-mi pthread)
 endif ()
-# TODO: why isn't this done by add_lldb_executable?
-target_link_libraries(lldb-mi ${LLDB_USED_LIBS})
 llvm_config(lldb-mi ${LLVM_LINK_COMPONENTS})
 set_target_properties(lldb-mi PROPERTIES VERSION ${LLDB_VERSION})

More information about the lldb-commits mailing list