[Lldb-commits] [PATCH] D18531: Allow gdbremote process to read modules from memory

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 29 06:47:10 PDT 2016

tberghammer added a comment.

What is your opinion about replacing the ProcessGDBRemote::LoadModuleAtAddress with the following code:

  ProcessGDBRemote::LoadModuleAtAddress (const FileSpec &file, lldb::addr_t base_addr, bool value_is_offset)
      DynamicLoader* loader = GetDynamicLoader();
      if (!loader)
          return nullptr;
      return loader->LoadModuleAtAddress(file, LLDB_INVALID_ADDRESS, base_addr, value_is_offset);

I think this should fix your problem while reducing the amount of code duplication we already has (I haven't tested it).


More information about the lldb-commits mailing list