[Lldb-commits] [PATCH] D18547: Fix infinite recursion in DWO file parsing

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 29 06:36:01 PDT 2016

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

Looks good

Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:334
@@ +333,3 @@
+    virtual std::unique_ptr<SymbolFileDWARFDwo>
+    GetDWOForCompileUnit(DWARFCompileUnit &dwarf_cu, const DWARFDebugInfoEntry &cu_die);
I would rename it to GetDwoSymbolFileForCompileUnit(....) as DWO in its own doesn't mean too much.


More information about the lldb-commits mailing list