[Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 28 22:43:11 PDT 2016

It's night here, so I will have a detailed look tomorrow.  But in the
meantime, some of the issues don't appear to be addressed.  For example the
issue about why logging is disabled, the disabled code in
ProcessWinMiniDump.cpp, and a few other things.  If you view the diff in
Phabricator, you can respond inline to each of those with some kind of
explanation if possible.

On Mon, Mar 28, 2016 at 10:26 PM Eran Ifrah <eran.ifrah at gmail.com> wrote:

> eran.ifrah updated this revision to Diff 51873.
> eran.ifrah marked 21 inline comments as done.
> eran.ifrah added a comment.
> An updated patch that fixes all your comments and in includes this one as
> well: http://reviews.llvm.org/D18520
> I also added new command line argument option to `CMake` :
> `-DMINGW_DEBUG=1` when passed from the command line, it adds `-g -O0` to
> the LLDB sources (only LLDB)
> Using the standard way `-DCMAKE_BUILD_TYPE=Debug` creates file too large
> for MinGW to handle
> http://reviews.llvm.org/D18519
> Files:
>   CMakeLists.txt
>   cmake/modules/AddLLDB.cmake
>   cmake/modules/LLDBConfig.cmake
>   include/lldb/Host/windows/win32.h
>   source/API/SystemInitializerFull.cpp
>   source/Host/common/OptionParser.cpp
>   source/Host/windows/EditLineWin.cpp
>   source/Host/windows/FileSystem.cpp
>   source/Host/windows/ProcessRunLock.cpp
>   source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp
>   source/Plugins/Process/Windows/Common/ProcessWindowsLog.h
>   source/Target/ProcessLaunchInfo.cpp
>   source/Utility/PseudoTerminal.cpp
>   tools/CMakeLists.txt
>   tools/argdumper/CMakeLists.txt
>   tools/driver/CMakeLists.txt
>   tools/driver/Driver.cpp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160329/53b88918/attachment-0001.html>

More information about the lldb-commits mailing list