[Lldb-commits] [PATCH] D18520: Initialize ProcessWindowsLive when building LLDB with MinGW

[Eran Ifrah via lldb-commits]

eran.ifrah added inline comments.

================
Comment at: source/API/SystemInitializerFull.cpp:90
@@ -89,3 +89,3 @@
 
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__MINGW32__)
 #include "lldb/Host/windows/windows.h"
----------------
zturner wrote:
> Just use `LLVM_ON_WIN32` for both of these places, otherwise looks good.
I tried using  `LLVM_ON_WIN32` but it does not defined with MinGW ( to confirm this, I placed an `#error` directive to ensure that it does not reach there, so I ended up using `__MINGW32__` which is defined for both MinGW32 and 64


http://reviews.llvm.org/D18520