[Lldb-commits] [PATCH] D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm

[Chaoren Lin via lldb-commits]

chaoren added a comment.

In http://reviews.llvm.org/D18481#383694, @zturner wrote:

> This seems very strange to me.  What if someone specifies those flags on the command line in the makefile instead of via some environment variables?


I don't think there's anything we can do about that unless we parse the Makefiles from within the test suite.  These kinds of flags are bad to hard code into the Makefiles anyway, unless there's a way to mark a test as thumb specific or hard float specific in the test suite, in which case we'd be using *those* indicators instead to filter for xfail. For now I think this is a pretty reasonable way to discriminate on the validity of failures based on compile flags.

> It also seems like a very specialized argument that we might use once or twice ever.


This applies to arbitrary compile flags. Though you probably won't ever need it for x86/x86_64, I can see it being useful for ARM and MIPS due to the sheer number of variations.


http://reviews.llvm.org/D18481