[Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 24 13:31:42 PDT 2016


zturner requested changes to this revision.
zturner added a comment.
This revision now requires changes to proceed.

This patch won't work.  `PyFile_AsFile` doesn't exist on Python 3.  Anything that you need done to make this work has to be wrapped up in `PythonFile` class as it was before, because that is the place where you can add Python version specific code to do different things with Py2 and Py3.


http://reviews.llvm.org/D18459





More information about the lldb-commits mailing list